Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create simple json target #125

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Create simple json target #125

wants to merge 2 commits into from

Conversation

jonnyeqt
Copy link

Description

Simple JSON target for emitting the entities and relations as json objects.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • [?] This PR includes tests, or tests are not required/relevant for this PR
  • I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR

@datnguye
Copy link
Owner

datnguye commented Dec 12, 2024 •
edited
Loading

Thanks @jonnyeqt for raising the PR!

I have a couple questions / comments please help to check out:

  • Can I ask for the use case of this JSON output?
  • Shall we include ALL attributes, e.g. table.description?
  • You should run poe format command to format your code and push another commit
  • Can you help to update the docs/ folder as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonnyeqt @datnguye